https://bugzilla.redhat.com/show_bug.cgi?id=1409780 --- Comment #1 from Michael Schwendt <bugs.michael@xxxxxxx> --- Just some drive-by comments as I won't be able to assist with golang stuff: "SRPM URL" points at spec file. One of the first things you may want to do is to point the fedora-review tool at this ticket: fedora-review -b 1409780 It will fetch the latest package files, perform a local build and check the built packages for lots of issues that will be relevant not only during package review. Every package maintainer ought to be aware of that tool and use it, too. > Version: 0.0.0 If there is no upstream version, this tag contains two superfluous '.0'. A simple Version: 0 would achieve the same thing. Also look up the git snapshot guidelines: https://fedoraproject.org/wiki/Packaging:Versioning Less macros in the spec file would be a good thing. Readability of this spec file is unusually low, also due to too many conditional sections that are only for other dists and will require a very careful review (e.g. if you ever turned off subpackage builds, it would be necessary to add proper Obsoletes/Provides tags for the remove packages). > %global provider github > %global provider_tld com > %global project hanwen > %global repo go-fuse > %global provider_prefix %{provider}.%{provider_tld}/%{project}/%{repo} > URL: https://%{provider_prefix} > Source0: https://%{provider_prefix}/archive/%{commit}/%{repo}-%{shortcommit}.tar.gz Even the package %name would be affected, if you touched any of these macro definitions, > Name: golang-%{provider}-%{project}-%{repo} but it isn't as easy as that, because there are extra requirements for renaming Fedora packages. %check section by default didn't test anything. And since your generate %files lists on-the-fly, do you even check for missing files? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx