[Bug 1409648] Review Request: python-olefile - Python package to parse, read and write Microsoft OLE2 files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1409648

Igor Gnatenko <ignatenko@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|                            |fedora-review+



--- Comment #5 from Igor Gnatenko <ignatenko@xxxxxxxxxx> ---
So, after full review -- still some issues, but easy to fix during import:

* E: wrong-script-interpreter /usr/lib/python3.6/site-packages/OleFileIO_PL.py
/usr/local/bin/python
* E: wrong-script-interpreter
/usr/lib/python3.6/site-packages/olefile/__init__.py /usr/local/bin/python 
* E: wrong-script-interpreter
/usr/lib/python3.6/site-packages/olefile/olefile.py /usr/bin/env python
-> find -type f -name '*.py' -exec sed -i -e '1{\@^#!/usr/bin/env python@d}' {}
';'

* E: wrong-script-end-of-line-encoding
/usr/lib/python3.6/site-packages/OleFileIO_PL.py
* E: wrong-script-end-of-line-encoding
/usr/lib/python3.6/site-packages/olefile/__init__.py
* W: wrong-file-end-of-line-encoding
/usr/share/doc/python3-olefile/Contribute.md
* W: wrong-file-end-of-line-encoding /usr/share/doc/python3-olefile/Install.md
* W: wrong-file-end-of-line-encoding /usr/share/doc/python3-olefile/License.md
* W: wrong-file-end-of-line-encoding
/usr/share/doc/python3-olefile/OLE_Overview.md
-> sed -i -e "s/\r//" *.md in %prep

Also please ask upstream to make such changes, there is no reason to not do
them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]