https://bugzilla.redhat.com/show_bug.cgi?id=1409648 --- Comment #1 from Igor Gnatenko <ignatenko@xxxxxxxxxx> --- Some preliminary comments: * %if 0%{?commit:1} -> %if %{defined commit} * %{__python2} setup.py build -> %py2_build * %{__python3} setup.py build -> %py3_build * %{__python2} setup.py install --skip-build --root %{buildroot} -> %py2_install * %{__python3} setup.py install --skip-build --root %{buildroot} -> %py3_install * You can use same summary by using %{summary} in subpackages * You can reuse %{url} in Source tag * Would be nice to not use macro in URL, so it will be clickable * Please move BuildRequires under subpackages * Tests are there, but not ran %{python3_sitelib}/* is too wide, please specify more carefully, like: %{python3_sitelib}/%{modname}-*.egg-info %{python3_sitelib}/%{modname}/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx