[Bug 1409000] Review Request: kwalletcli - CLI for the KDE Wallet

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1409000

Raphael Groner <projects.rg@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |projects.rg@xxxxxxxx



--- Comment #1 from Raphael Groner <projects.rg@xxxxxxxx> ---
Thanks for your interesting review request.

> %if 0%{?fedora}
> BuildRequires:  kf5-kcoreaddons-devel
> BuildRequires:  kf5-ki18n-devel
> BuildRequires:  kf5-kwallet-devel
> %else
> BuildRequires:  kdelibs-devel
> %endif

kf5-kwallet is available in EPEL7, why do you link against kdelibs-devel? Maybe
it's better to have support for both KDE4 and KF5, as the description says. My
doubt that we want support for KDE 3 in any case, please remove that from the
description as it's confusing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]