[Bug 1409404] New: Review Request: blueberry - Bluetooth configuration tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1409404

            Bug ID: 1409404
           Summary: Review Request: blueberry - Bluetooth configuration
                    tool
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: nobody@xxxxxxxxxxxxxxxxx
          Reporter: bjoern.esser@xxxxxxxxx
        QA Contact: extras-qa@xxxxxxxxxxxxxxxxx
                CC: package-review@xxxxxxxxxxxxxxxxxxxxxxx



Description:

  Bluetooth configuration tool depending on gnome-bluetooth.


Koji Build:

  https://koji.fedoraproject.org/koji/taskinfo?taskID=17139111


Reported issues:

  - glib-compile-schemas is run in %postun and %posttrans if package has
    *.gschema.xml files.
    Note: gschema file(s) in blueberry
    See:
    http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#GSettings_Schema

    ---> Obsolete for Fedora 24+.  See link above.

  - Package installs a %{name}.desktop using desktop-file-install or desktop-
    file-validate if there is such a file.

    ---> Is run properly during %install-section.

  - Package requires other packages for directories it uses.
    Note: No known owner of /usr/share/locale/frp,
    /usr/share/locale/frp/LC_MESSAGES
  - Package must own all directories that it creates.
    Note: Directories without known owners: /usr/share/locale/frp,
    /usr/share/locale/frp/LC_MESSAGES

    ---> Bug in filesystem-package (rhbz#1409402).

  - gtk-update-icon-cache is invoked in %postun and %posttrans if package
    contains icons.  Note: icons in blueberry

    ---> Needed scriptlets are present.

  - %config files are marked noreplace or the reason is justified.

    ---> The file is a desktop-file for xdg/autostart.

  - If the source package does not include license text(s) as a separate
    file from upstream, the packager SHOULD query upstream to include it.

    ---> See:  https://github.com/linuxmint/blueberry/pull/27


Rpmlint:

  Checking: blueberry-1.1.9-0.1.fc26.noarch.rpm
            blueberry-1.1.9-0.1.fc26.src.rpm
  blueberry.noarch: W: spelling-error %description -l en_US bluetooth ->
Bluetooth, blue tooth, blue-tooth
  blueberry.src: W: spelling-error %description -l en_US bluetooth ->
Bluetooth, blue tooth, blue-tooth

  ---> False positive, reported from the words 'gnome-desktop'.

  blueberry.noarch: W: only-non-binary-in-usr-lib

  ---> Package is noarch.

  blueberry.noarch: W: no-manual-page-for-binary blueberry
  blueberry.noarch: W: no-manual-page-for-binary blueberry-tray

  ---> Mentioned binaries are wrapper for gui-apps without cli-switches.

  blueberry.noarch: E: invalid-lc-messages-dir
/usr/share/locale/ber/LC_MESSAGES/blueberry.mo

  ---> Bug in rpmlint (rhbz#1409403).

  blueberry.src:80: E: hardcoded-library-path in %{_prefix}/lib/%{name}

  ---> There is no macro for noarch'ed '/usr/lib'.

  2 packages and 0 specfiles checked; 2 errors, 5 warnings.


FAS-User:

  besser82


Urls:

  Spec URL:  https://besser82.fedorapeople.org/review/blueberry.spec
  SRPM URL: 
https://besser82.fedorapeople.org/review/blueberry-1.1.9-0.1.fc26.src.rpm


Thanks for review in advance!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux