[Bug 1409138] Review Request: pixiewps - An offline WPS bruteforce utility

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1409138



--- Comment #5 from Michael Schwendt <bugs.michael@xxxxxxx> ---
Things you may want to look into:


  | %prep
  | %setup -n pixiewps-master

The %setup macro will extract the source archive automatically (also if you
stick to the .zip file instead of a .tgz).

The -n option will tell RPM the name of the top-level source directory. If not
using -n, the default would be to enter directory %{name}-%{version}.

rpmbuild is clever enough to enter this top-level source directory for every
build section (such as %build, %install, %check and even the %files list). You
can see that in the rpmbuild output.


 | %build
 | cd src
 | CFLAGS="%{optflags}" make %{?_smp_mflags}

This would work already to build with Fedora's global C compiler flags, but the
Makefile adds some flags such as -O3 and therefore more will be necessary (such
as a trivial patch or some guarded "sed" magic) to adhere to the guidelines:
https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags


  | %install
  | cd src
  | %make_install

This _would_ work. Examine output of "rpm -E %make_install" to see what that
macro does. However, currently the Makefile is affected by a bug (a duplicated
$DESTDIR prefix). There is a pull request at github to fix that. A trivial
patch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]