[Bug 1403423] Review Request: visualboyadvance-m - High compatibility Gameboy Advance Emulator combining VBA builds

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1403423



--- Comment #7 from Jeremy Newton <alexjnewt@xxxxxxxxx> ---
(In reply to Neal Gompa from comment #6)
> (In reply to Jeremy Newton from comment #5)
> > (In reply to Neal Gompa from comment #4)
> > > [!]: Package must own all directories that it creates.
> > >      Note: Directories without known owners:
> > >      /usr/share/icons/hicolor/96x96/apps,
> > >      /usr/share/icons/hicolor/64x64/apps, /usr/share/icons/hicolor/22x22,
> > >      /usr/share/icons/hicolor/48x48/apps,
> > >      /usr/share/icons/hicolor/22x22/apps,
> > >      /usr/share/icons/hicolor/32x32/apps, /usr/share/icons/hicolor/96x96,
> > >      /usr/share/icons/hicolor/16x16/apps,
> > >      /usr/share/icons/hicolor/scalable/apps,
> > >      /usr/share/icons/hicolor/16x16, /usr/share/icons/hicolor/128x128/apps,
> > >      /usr/share/icons/hicolor/128x128, /usr/share/icons/hicolor/64x64,
> > >      /usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor/32x32,
> > >      /usr/share/icons/hicolor, /usr/share/icons/hicolor/scalable
> > > 
> > > - Note that this issue can be solved by adding "BuildRequires:
> > > hicolor-icon-theme" to the spec and "Requires: hicolor-icon-theme" to the
> > > main package.
> > 
> > Nice catch, although only the build require is necessary, as the
> > auto-dependencies should pick this up.
> > 
> 
> Unfortunately, no, it will not automatically pick it up, since we don't have
> a dependency generator for checking for the mere existence of the directory
> paths and setting that up.

Really? I guess I'm mistaken, I thought it picks up on some key directories. I
assume all packages that install hicolor icons need this? If so, I need to fix
up a few of my own.

> 
> > %config(noreplace) /etc/%{shortname}.cfg
> 
> Please replace usage of "/etc" with "%{_sysconfdir}"

Done.

Note that I didn't bump the release:

Spec URL: https://dl.dropboxusercontent.com/u/42480493/visualboyadvance-m.spec
SRPM URL:
https://dl.dropboxusercontent.com/u/42480493/visualboyadvance-m-2.0.0-0.4.Beta3.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]