https://bugzilla.redhat.com/show_bug.cgi?id=1403423 --- Comment #5 from Jeremy Newton <alexjnewt@xxxxxxxxx> --- (In reply to Neal Gompa from comment #4) > A fedora-review run indicates that there are a couple of issues: > > - update-desktop-database is invoked in %post and %postun if package > contains desktop file(s) with a MimeType: entry. > Note: desktop file(s) with MimeType entry in visualboyadvance-m > See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop- > database According to the wiki: "This scriptlet SHOULD NOT be used in Fedora 25 or later." So I'll wrap it in an %if. > [!]: Package must own all directories that it creates. > Note: Directories without known owners: > /usr/share/icons/hicolor/96x96/apps, > /usr/share/icons/hicolor/64x64/apps, /usr/share/icons/hicolor/22x22, > /usr/share/icons/hicolor/48x48/apps, > /usr/share/icons/hicolor/22x22/apps, > /usr/share/icons/hicolor/32x32/apps, /usr/share/icons/hicolor/96x96, > /usr/share/icons/hicolor/16x16/apps, > /usr/share/icons/hicolor/scalable/apps, > /usr/share/icons/hicolor/16x16, /usr/share/icons/hicolor/128x128/apps, > /usr/share/icons/hicolor/128x128, /usr/share/icons/hicolor/64x64, > /usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor/32x32, > /usr/share/icons/hicolor, /usr/share/icons/hicolor/scalable > > - Note that this issue can be solved by adding "BuildRequires: > hicolor-icon-theme" to the spec and "Requires: hicolor-icon-theme" to the > main package. Nice catch, although only the build require is necessary, as the auto-dependencies should pick this up. > [!]: Package does not own files or directories owned by other packages. > Note: Dirs in package are owned also by: /usr/share/vbam(vbam-gtk) > > - If this is intentional, please put a comment in the spec for why it is > this way. I can imagine why it might be this way (the two programs are > independent and not necessarily both installed as they are not > interdependent). This is the old package name for visualboyadvance-m in rpmfusion. It's already provided and obsoleted, see lines 41-43 of the spec. Note that I also maintain this package in RPMFusion, so it will be retired once this is accepted. New files: Spec URL: https://dl.dropboxusercontent.com/u/42480493/visualboyadvance-m.spec SRPM URL: https://dl.dropboxusercontent.com/u/42480493/visualboyadvance-m-2.0.0-0.4.Beta3.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
