[Bug 1409241] Review Request: ufw - Uncomplicated Firewall

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1409241



--- Comment #4 from Kevin Kofler <kevin@xxxxxxxxxxxxxxxx> ---
> * Could you please use the official sources from the Launchpad project? It 
> appears to be available at:
> https://launchpad.net/ufw/0.35/0.35/+download/ufw-0.35.tar.gz

I'll fix that. (I hope it is really the same source…) The use of the Ubuntu
package's .orig.tar.gz is a leftover from the times of the 0.34 prereleases,
where the Ubuntu packages had various prereleases of 0.34 cut directly from the
upstream SCM. There were months between the upstream 0.33 and 0.34 releases and
the 0.34 prereleases were the only ones supporting Python 3 at the time.

> * In the %prep phase, you're deleting profiles. Why?

I am deleting the backups left by the %patchN -b .foo invocations because the
broken build system installs them if I don't do that.

I am not just leaving off the -b .foo because then I sometimes get .orig
backups. (The %patchN macros do not understand "--no-backup-if-mismatch".)

> * In your %build and %install phases, please use %py3_build and %py3_install 
> instead of calling them directly.

Ah? I'll fix that, too.

I'll be uploading a fixed specfile ASAP.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]