Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Net-SFTP - Secure File Transfer Protocol client https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248414 jochen@xxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |jochen@xxxxxxxxxxxxxxx Flag| |fedora-review+ ------- Additional Comments From jochen@xxxxxxxxxxxxxxx 2007-07-16 15:47 EST ------- Good: + Package meets naming guidelines + SPEC file name matches with package base name + SPEC file has consistantly macro usage + License is GPL or Artistic + Upstream Tar ball contains a verbatim copy of the license + Package contains verbatim copy of the license + License tag matches with license in the tar ball + SPEC file is written in English + SPEC file is legible + Tar ball matches with upstream (md5sum: 8383eb0839178cab8cbfe619b232b8c0) + Package has proper build root + Package has no redundant BuildRequires + Package has no sub packages + Local build works properly + Package has proper %clean section + Build root will cleand at the beginning of the %install section + Package has proper %defattr and proper file permissions + Package %doc files doesn't affect runtime + Packages file list has not duplicate files + Package doesn't contains file or directories owned by other packages + Local install and uninstall works fine + Rpmlint is quite for source and binary package + Mock build works fine Devel (x86_64, ppc64, ppc) *** You are APPROVED *** -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review