https://bugzilla.redhat.com/show_bug.cgi?id=1402656 Sachidananda Urs <surs@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |surs@xxxxxxxxxx --- Comment #1 from Sachidananda Urs <surs@xxxxxxxxxx> --- This is an unofficial review of the package: I see these warnings when I run rpmlint: bdsync.src: W: no-url-tag Can you please add an URL tag? bdsync.x86_64: E: incorrect-fsf-address /usr/share/licenses/bdsync/COPYING You might have put the address wrong for the above. And under license, can you mention GPLv2 or GPLv3 instead of just GPL. https://fedoraproject.org/wiki/How_to_create_an_RPM_package#SPEC_file_overview In %install, removing buildroot is optional and should be removed We don't need %clean section anymore. ref: https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx