[Bug 1406958] Review Request: python-ipykernel - IPython Kernel for Jupyter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1406958



--- Comment #4 from gil cattaneo <puntogil@xxxxxxxxx> ---
Issues:

[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "BSD (3 clause)", "Unknown or generated". 61 files have unknown
     license. Detailed output of licensecheck in /home/gil/1406958-python-
     ipykernel/licensecheck.txt

The following source files are without license headers:

ipykernel-4.5.2/ipykernel/__init__.py
ipykernel-4.5.2/ipykernel/_main.py
ipykernel-4.5.2/ipykernel/_version.py
ipykernel-4.5.2/ipykernel/datapub.py
ipykernel-4.5.2/ipykernel/embed.py
ipykernel-4.5.2/ipykernel/ipkernel.py
ipykernel-4.5.2/ipykernel/log.py
ipykernel-4.5.2/ipykernel/comm/__init__.py
ipykernel-4.5.2/ipykernel/inprocess/__init__.py
ipykernel-4.5.2/ipykernel/inprocess/constants.py
ipykernel-4.5.2/ipykernel/inprocess/tests/__init__.py
ipykernel-4.5.2/ipykernel/pylab/__init__.py
ipykernel-4.5.2/ipykernel/tests/test_pickleutil.py
ipykernel-4.5.2/ipykernel/tests/test_start_kernel.py

ipykernel-4.5.2/docs/conf.py
ipykernel-4.5.2/examples/embedding/inprocess_qtconsole.py
ipykernel-4.5.2/examples/embedding/inprocess_terminal.py
ipykernel-4.5.2/examples/embedding/internal_ipkernel.py
ipykernel-4.5.2/examples/embedding/ipkernel_qtapp.py
ipykernel-4.5.2/examples/embedding/ipkernel_wxapp.py

Please, ask to upstream to confirm the licensing of code and/or content/s, and
add license headers
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Clarification

[?]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/doc/python-ipykernel,
     /usr/lib/python3.6/site-packages, /usr/lib/python3.6
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/doc/python-
     ipykernel, /usr/lib/python3.6/site-packages, /usr/lib/python3.6

  /usr/share/doc/python-ipykernel


[!]: Uses parallel make %{?_smp_mflags} macro.

 make html >> make %{?_smp_mflags} html


[!]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed
     files.
 cp -favr docs/_build/html %{buildroot}%{_docdir}/%{name}

Please; use:
Source0:   
https://github.com/ipython/%{modname}/archive/%{version}/%{modname}-%{version}.tar.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]