https://bugzilla.redhat.com/show_bug.cgi?id=1404043 --- Comment #8 from Honggang LI <honli@xxxxxxxxxx> --- (In reply to Jarod Wilson from comment #5) > > > honli: systemd and dracut also needed. > > These already get pulled in. No, you missed systemd. As a result, your new srpm can't be rebuilt. > > > honli: You also delete a few necessary "Requires:" tags. > > honli: Please see review-comment.txt for details. > > From that doc: > > > honli: Please add "Requires:" entries against rsyslog, systemd, kmod, > > honli: logrotate, initscripts, and dracut. > > None of these need to be listed explicitly, so far as I know. These are all > things that are expected to be on the system, thus no need to call them out > specifically. Several of them are already requirements of the kernel. > I would suggest to list explicitly. Otherwise fedora-review tool will complaint. [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/udev, /usr/share/doc /rdma-core-12, /etc/rsyslog.d, /etc/sysconfig/network-scripts, /etc/udev/rules.d, /etc/udev, /etc/logrotate.d, /usr/lib/udev/rules.d [ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/include/infiniband (ibacm-devel, libibverbs-devel), /usr/lib/dracut/modules.d/05rdma(rdma), /usr/include/rdma(kernel- headers), /etc/rdma(rdma, ibacm) > > honli: %setup -q ??? > > %build > > Why? I prefer verbose myself, so you can see more easily in logs if > something goes wrong. OK. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx