[Bug 1406946] Review Request: python-httpbin - HTTP Request & Response Service, written in Python + Flask

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1406946



--- Comment #4 from Neal Gompa <ngompa13@xxxxxxxxx> ---
A couple of questions here:

> Source0:        https://github.com/%{github_owner}/%{github_name}/archive/%{github_commit}/%{github_name}-%{version}.tar.gz

Why are you using the GitHub commit to do this? It forces you to declare a
folder name in %autosetup later on. GitHub does provide
https://github.com/Runscope/httpbin/archive/v0.5.0.tar.gz as an option.

You can use it as a Source0 like so:
https://github.com/%{github_owner}/%{github_name}/archive/v%{version}/%{github_name}-%{version}.tar.gz

> LANG=en_US.UTF-8 %py3_build

Why the LANG? Could you put a comment explaining why that was necessary?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]