https://bugzilla.redhat.com/show_bug.cgi?id=1392090 Athos Ribeiro <athoscribeiro@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(athoscribeiro@gma | |il.com) | --- Comment #5 from Athos Ribeiro <athoscribeiro@xxxxxxxxx> --- Hi Peter, This is not a problem in this package, but I'd suggedt to be careful with wildcards in python3 packages, since sometimes your package may end up owning %{python3_sitelib}/__pycache__, which belongs to system-python-libs spec file line 2 reads: %define with_tests 0 Guidelines sugest we use %global instead, as you can see in [1]. Note that this is not a must. The Summary tag ends with period a period. Please see [2]. After your feedback on those points I will consider this review done, sice the package looks good. We would still need to find a solution for bug 1392089 in order to include python2-zeroconf in fedora, since this bug depends on it. [1] https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define [2] https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx