https://bugzilla.redhat.com/show_bug.cgi?id=1342688 --- Comment #3 from Julien Enselme <jujens@xxxxxxxxx> --- I guess this is to revive this package: https://admin.fedoraproject.org/pkgdb/package/rpms/python-livereload/ - In the description for the Python 3 subpackage Python2 -> Python3 - Please include license in docs subpackage - You have more dependencies than what seems required from setup.py (django, certifi, … vs only six and tornad). Are they realy necessary? - You must correct the shebang of the main script (see the error of rpmlint) - From what I understand, the package provide the same functions on Python 3 and 2. So from what I understand from the guidelines (https://fedoraproject.org/wiki/Packaging:Python#Executables_in_.2Fusr.2Fbin) only the Python 3 sub-package should contain the executable script. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://admin.fedoraproject.org/pkgdb/package/python-livereload See: https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names ===== MUST items ===== Generic: [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [X]: License field in the package spec file matches the actual license. Note: Cannot run licensecheck: Command 'licensecheck -r /var/lib/mock /fedora-rawhide-x86_64/root/builddir/build/BUILD/python- livereload-2.5.0' returned non-zero exit status 255 [!]: License file installed when any subpackage combination is installed. [?]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/python3.5/site- packages/livereload(livereload), /usr/lib/python3.5/site- packages/livereload/vendors(livereload), /usr/lib/python3.5/site- packages/livereload/__pycache__(livereload) [X]: Package contains no bundled libraries without FPC exception. [X]: Changelog in prescribed format. [X]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [X]: Package uses nothing in %doc for runtime. [X]: Package consistently uses macros (instead of hard-coded directory names). [X]: Package is named according to the Package Naming Guidelines. [X]: Package does not generate any conflict. [X]: Package obeys FHS, except libexecdir and /usr/target. [X]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [X]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [X]: Package is not known to require an ExcludeArch tag. [X]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 71680 bytes in 12 files. [X]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [X]: Python eggs must not download any dependencies during the build process. [X]: A package which is used by another package via an egg interface should provide egg info. [!]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [X]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-livereload , python2-livereload , python-livereload-docs [?]: Package functions as described. [X]: Latest version is packaged. [X]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [X]: %check is present and all tests pass. [X]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-livereload-2.5.0-1.fc26.noarch.rpm python2-livereload-2.5.0-1.fc26.noarch.rpm python-livereload-docs-2.5.0-1.fc26.noarch.rpm python-livereload-2.5.0-1.fc26.src.rpm python3-livereload.noarch: W: no-manual-page-for-binary livereload python2-livereload.noarch: W: no-manual-page-for-binary livereload-py2 python-livereload-docs.noarch: E: wrong-script-interpreter /usr/share/doc/python-livereload-docs/example/server.py /usr/bin/env python 4 packages and 0 specfiles checked; 1 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- python-livereload-docs.noarch: E: wrong-script-interpreter /usr/share/doc/python-livereload-docs/example/server.py /usr/bin/env python python3-livereload.noarch: W: no-manual-page-for-binary livereload python2-livereload.noarch: W: no-manual-page-for-binary livereload-py2 3 packages and 0 specfiles checked; 1 errors, 2 warnings. Requires -------- python-livereload-docs (rpmlib, GLIBC filtered): python3-livereload (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3-certifi python3-six python3-tornado python2-livereload (rpmlib, GLIBC filtered): /usr/bin/python2 python(abi) python-backports-ssl_match_hostname python-tornado python2-certifi python2-six Provides -------- python-livereload-docs: python-livereload-docs python3-livereload: livereload python3-livereload python3.5dist(livereload) python3dist(livereload) python2-livereload: python-livereload python2-livereload python2.7dist(livereload) python2dist(livereload) Source checksums ---------------- https://github.com/lepture/python-livereload/archive/v2.5.0.tar.gz : CHECKSUM(SHA256) this package : 79eca97371dd7d565f81372889f27d4f71a5efaba7f973e7e160c5556ee86be8 CHECKSUM(SHA256) upstream package : 79eca97371dd7d565f81372889f27d4f71a5efaba7f973e7e160c5556ee86be8 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1342688 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx