https://bugzilla.redhat.com/show_bug.cgi?id=1395947 --- Comment #2 from Martin Kolman <mkolman@xxxxxxxxxx> --- (In reply to Fabian Affolter from comment #1) > - rpmlint is not happy (check below) > - The ownership of the '/usr/lib/python*/site-packages/pydbus/' Changed ownership lines from: %{python2_sitelib}/* %{python3_sitelib}/* To: %{python2_sitelib}/pydbus/* %{python3_sitelib}/pydbus/* (Hope I understand this correctly.) > - The examples should go into a examples subpackage. Add an -examples subpackage. > - Consider to add a %check section as tests are available. I've tried to run the tests, but they always fail with an exception. As there are some docker files in the tests directy it looks like some additional setup, possibly out of scope of what we can reasonably run during build in Koji. In any case I've opened an upstream issue about this to get a clarififcation: https://github.com/LEW21/pydbus/issues/40 > - pydbus.spec should be python-pydbus.spec Fixed. So the new URLs are: Spec URL: https://m4rtink.fedorapeople.org/packaging/pydbus/python-pydbus.spec SRPM URL: https://m4rtink.fedorapeople.org/packaging/pydbus/python-pydbus-0.5.1-1.fc25.src.rpm > - Download URL is wrong Fixed: https://files.pythonhosted.org/packages/source/e/%{srcname}/%{srcname}-%{version}.tar.gz This currently translates to: https://files.pythonhosted.org/packages/source/e/pydbus/pydbus-0.5.1.tar.gz Which works. > - 'URL: https://pypi.python.org/pypi/pydbus/%{srcname}' is very copy-&-paste > unfriendly for humans. Fixed the URL, it is now just: https://pypi.python.org/pypi/pydbus For the Fedora Review stuff: > [-]: If (and only if) the source package includes the text of the > license(s) in its own file, then that file, containing the text of the > license(s) for the package is included in %license. Looks like the LICENSE file is missing from the PyPI tarball for some reason - I've reported an issues upstream: https://github.com/LEW21/pydbus/issues/39 > [!]: Package contains systemd file(s) if in need. I have no idea what this means - I haven't been able to find any explanation anywhere. Looking at the source code of the check: class CheckSystemdScripts(GenericCheckBase): ''' systemd files if applicable. ''' def __init__(self, base): GenericCheckBase.__init__(self, base) self.url = 'https://fedoraproject.org/wiki/Packaging:Guidelines' self.text = 'Package contains systemd file(s) if in need.' self.automatic = True self.type = 'MUST' self.needs.append('CheckDaemonCompileFlags') def run_on_applicable(self): if self.checks.checkdict['CheckDaemonCompileFlags'].is_na: self.set_passed(self.PENDING) else: self.set_passed(self.PASS) It seems to be trying to check daemon compilation flags or something ? That would mean it's a flase positive as pydbus is neither compiled & not a daemon. Also no longer happens when I run fedora-review locally (Rawhide Mock config). > [!]: Package complies to the Packaging Guidelines I guess this should be fixed by the fixes mentioned above ? > [!]: Sources can be downloaded from URI in Source: tag > Note: Could not download Source0: Should be fixed by the correct source URL. > [!]: If the source package does not include license text(s) as a separate > file from upstream, the packager SHOULD query upstream to include it. Mentioned above - license missing in tarball has been reported to upstream. > [!]: SourceX tarball generation or download is documented. > Note: Package contains tarball without URL, check comments Should be also fixed by the correct tarball URL. > [-]: %check is present and all tests pass. As mentioned above, test are currently either broken or require special testing setup. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx