[Bug 1398922] Review Request: uftrace - User-space function call tracer for C and C++ programs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1398922



--- Comment #11 from Benjamin Kircher <benjamin.kircher@xxxxxxxxx> ---
Hi Michael. Thank you for looking into this.

> > * I think license is GPLv2+, not GPLv2
>
> It's useless to write that without giving a rationale.
>
> Have you pointed "fedora-review -b 1398922" at this ticket yet to see which
> test results it comes up with?
Not sure if you asked Igor or me here  (Igor, I presume). I don't want to get
ahead of things here but anyway: Yes I did just now.

rpmlint reports 3 errors (incorrect-fsf-address) and lots of warnings
(partially useful) i.e., about those unversioned so-files in the package.

For your convenience, please find results here:
https://raw.githubusercontent.com/bkircher/uftrace-fedora/master/review.txt

Things I should fix (I guess, waiting for input from you guys here):

1) These BR are not needed: gcc
2) Unversioned so-files not in -devel subpackage. Should we open a ticket with
Fedora Packaging Committee as per
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#DevelPackages
because of that?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]