https://bugzilla.redhat.com/show_bug.cgi?id=1398922 --- Comment #8 from Benjamin Kircher <benjamin.kircher@xxxxxxxxx> --- Thank you. > * ./configure -> %configure > Usually, but unfortunately it's not the case right now. Correct, configure is a shell script here. > Main problem is that CFLAGS/LDFLAGS are ignored. > you can do something like: > export CFLAGS="%{__global_cflags}" > exprot LDFLAGS="%{__global_ldflags}" before configure call Fixed. > * rm -rf $RPM_BUILD_ROOT is not needed Fixed. > * I think license is GPLv2+, not GPLv2 Not 100% sure on this one. The license header used in the source files explicitly states version 2. The usual "either version 2 of the License, or (at your option) any later version" is missing here in the text. I ask the author to clarify this. > * Missing BuildRequires: gcc Fixed. > * I would recommend make URL without macro, so it will be easily clickable Makes sense. Followed your recommendation. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx