[Bug 1401276] Review Request: python-grako - Python grammer compiler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1401276



--- Comment #7 from Iryna Shcherbina <ishcherb@xxxxxxxxxx> ---
(In reply to Eric Smith from comment #6)
> I apologize for wasting your time! From my shell history, I see that I built
> 3.18.0-2 locally, but then ran rpmlint and koji with -1.  :-(

No problem at all.

I have two more small suggestions after the changes:

1) Tests should be run after the %install procedure, so place %check after
%install section.
2) You might consider using `pushd` instead of `cd`:
pushd examples/regex
...
popd

Apart from the above, everything looks good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]