[Bug 1393947] Review Request: cinch - A tool for provisioning Jenkins components for CI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1393947



--- Comment #6 from Fl@sh <alex.mail.1534@xxxxxxxxx> ---
(In reply to greg.hellings from comment #5)
> New SRPM:
> https://fedorapeople.org/~greghellings/cinch/cinch-0.2.1-2.fc25.src.rpm
> 
> I added the %license line
> I switched python-devel to python2-devel instead
> 
> I'm guessing that's what you were meaning when you called out python-devel?
> It does need a Python development package in order to install.

About python-devel: fedora-review report suggests python2-devel for python2
packages, because python2-devel is a another provided name of python-devel.

I think that need to rename package to according with guidelines
https://fedoraproject.org/wiki/Packaging:Naming?rd=Packaging:NamingGuidelines#Python_modules
.
If you want develop package on python2 only, then it will be python-cinch as
example, else python2-chinch (python3-cinch for python3).

Also, see for common case for Source0:
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL .
Then this can be in your case:
https://github.com/RedHatQE/%{name}/archive/v%{version}.tar.gz . It is more
usable and readable.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]