https://bugzilla.redhat.com/show_bug.cgi?id=1398949 --- Comment #22 from Jeremy Newton <alexjnewt@xxxxxxxxx> --- (In reply to MartinKG from comment #21) > New bear Package: > Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/bear.spec > SRPM URL: > https://martinkg.fedorapeople.org/Review/SRPMS/bear-0.7.0-0.5gitac6be8b.fc25. > src.rpm > > %changelog > * Tue Dec 13 2016 Martin Gansser <martinkg@xxxxxxxxxxxxxxxxx> - > 0.7.0-0.5gitac6be8b > - Dropped subpkg engine/factory-devel because unversioned files needed at > runtime > - Add subpkg %%{name}-devel To fix asgp, change: > install -D cmake-helper/bear-config.cmake %{buildroot}%{_includedir}/%{name}/cmake-helper/ into > install -D cmake-helper/*.cmake %{buildroot}%{_includedir}/%{name}/cmake-helper/ (Does install allow wildcards?) As all of these cmake files seem to be required. As well, the following is incorrect: > %files devel > %{_includedir}/%{name}/* should be > %files devel > %{_includedir}/%{name} That way the devel package owns this folder (omitting %dir is recursive). Furthermore, some cleanup suggestions: -The following > %dir %{_libdir}/%{name} > %{_libdir}/%{name}/lib%{name}*.so > %exclude %{_libdir}/%{name}/lib%{name}-editor.so can be changed to: > %{_libdir}/%{name} > %exclude %{_libdir}/%{name}/lib%{name}-editor.so As this should be functionally the same - The following: > %dir %{_datadir}/%{name}-factory/ > %dir %{_datadir}/%{name}-factory/images/ > %dir %{_datadir}/%{name}-factory/item-description/ > %dir %{_datadir}/%{name}-factory/item-description/generic > %{_datadir}/%{name}-factory/images/ > %{_datadir}/%{name}-factory/item-description/ can be changed to: > %{_datadir}/%{name}-factory As "factory" owns everything in %{_datadir}/%{name}-factory anyway. Side note, the following should probably be moved to devel as well: > %{_datadir}/cmake/%{name}-engine -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx