https://bugzilla.redhat.com/show_bug.cgi?id=1404012 Miroslav Suchý <msuchy@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |msuchy@xxxxxxxxxx --- Comment #2 from Miroslav Suchý <msuchy@xxxxxxxxxx> --- Preliminary review: * you are missing systemd snippets https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#Systemd * it is shame that you start with python2 when everything is being moved to python3 :( (but it does not block the review) * there are test in tar.gz, but not used in %check. Any reason for that? * it would be nice to have man pages for /usr/bin/* tools -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx