https://bugzilla.redhat.com/show_bug.cgi?id=1312303 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #6 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- > FIX: Please add following build-requires: > perl(File::Temp) - t/06-no-such-entry.t:10, t/07-error-codes.t:10 > perl(Net::LDAP::LDIF) - t/06-no-such-entry.t:9, t/06-no-such-entry.t:9 > perl(IO::Socket::INET) - t/03-socket.t:10 +BuildRequires: perl(File::Temp) +BuildRequires: perl(IO::Socket::INET) +BuildRequires: perl(Net::LDAP::LDIF) Ok > FIX: The latest version is 0.22. There is no code change. Please update it before submit. > TODO: Please replace PERL_INSTALL_ROOT with more common DESTDIR. -%{__make} pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT +%{__make} pure_install DESTDIR=$RPM_BUILD_ROOT Ok Otherwise the package looks good. Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx