https://bugzilla.redhat.com/show_bug.cgi?id=1369708 --- Comment #63 from Yunying Sun <yunying.sun@xxxxxxxxx> --- > > Questions left: > > 1. > N/A* %check is present and all tests pass. > > Is the %check section a MUST? > > it's a SHOULD > (https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/ > Guidelines#Test_Suites), I would say if it's technically possible to run the > test-suite, then it makes sense to run even during the build, it can be a > slightly different environment than upstream uses (eg. stricter compiler > flags) or it can test all architectures (not this case) While in case of this package, Wei Gang suggested "unit tests should not be added into the build process of distro package", mainly due to: 1. Unit test code in upstream TPM2.0-TSS is not well organized yet, they are still working to add more formal unit test cases and make unit tests runnable during build process. 2. Currently, the unit test code is only intended to help developer addressing wrong changes to the code, and the formal released upstream code should have already been tested well. So I'd prefer not adding %check this time, if that's ok from you. Possibly I can add it later when unit test has been verified to be working well during build process for upstream. > > 2. koji build always fail with certification failure(re-fetched cert through > > fedora-packager-setup for couple of times but error remains same), and COPR > > build is still pending after being submitted for over 2 hours. Is there > > something wrong known with Koji & COPR build servers today? > > koji switched to kerberos based authentication today, please see > https://lists.fedoraproject.org/archives/list/devel-announce@lists. > fedoraproject.org/message/JK267PSDD53I2KGONDLFA5D4JWYXKZTQ/ for details Thanks for the info. Just managed to start koji build and it succeeds: https://koji.fedoraproject.org/koji/taskinfo?taskID=16862199 The COPR build also completed successfully: https://copr.fedorainfracloud.org/coprs/yunyings/tpm2-tss/build/487392/ Please help to review again. Thanks a lot. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx