[Bug 1398949] Review Request: bear - Game engine and editors dedicated to creating great 2D games

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1398949



--- Comment #20 from Jeremy Newton <alexjnewt@xxxxxxxxx> ---
(In reply to Tom "spot" Callaway from comment #19)
> (In reply to Jeremy Newton from comment #18)
> 
> > Well any libraries needed for run-time should be placed into the main
> > package, and any libraries or header/source files needed for build time
> > should be placed into the devel package. (you may have to install the devel
> > headers manually).
> > 
> > The unversioned libraries should realistically be fixed upstream IMHO.
> > plee-the-bear and asgp should just BuildRequire the bear-engine-devel
> > package and build without requiring two SOURCE tarballs.
> 
> Well put. The packages in this review are not setup like this, and they'd
> need to be adjusted to have the .so files in the main package (they're all
> needed at runtime).
> 
> Once these packages are fixed, I can see how much work it will be to rewire
> plee-the-bear to use them instead of its own bundled copy of bear.

Sounds good.

@MartinKG

You should be able to just manually copy all the needed devel files like so:

install -D cmake-helper/bear-config.cmake
%{buildroot}%{_includedir}/%{name}/cmake-helper/
for file in $(find bear-engine/{core,lib}/src -name *.hpp);
do
    install -D $file %{buildroot}%{_includedir}/%{name}/$file
done

Make a devel subpackage (bear-devel) for these files, and all the lib's should
move back to the respective engine or factory packages.

In asgp/plee-the-bear, all you need to do is remove bear, add bear-devel as a
build require, and then add the following cmake parameter:
-DBEAR_ROOT_DIRECTORY=%{_includedir}/bear

I'm not 100% sure if this will work, so please test this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]