https://bugzilla.redhat.com/show_bug.cgi?id=1398949 --- Comment #18 from Jeremy Newton <alexjnewt@xxxxxxxxx> --- (In reply to Tom "spot" Callaway from comment #17) > (In reply to Tom "spot" Callaway from comment #16) > > Do you have another package (besides plee-the-bear) that depends on the bear > > library? > > Replying to myself, I see that andy-super-great-park does. I guess the > question is whether it is simpler to separate this out like this, or have > plee-the-bear spit out a library package (bear-libs & bear-libs-devel). I would say split it out, but it's up to you how you want to do it. I figure it would be cleaner, and we'll have one source per package. I made some comments upstream, but packaging the private libraries should be ok for now: https://github.com/j-jorge/plee-the-bear/issues/5 We can just install the headers manually for now. I'm assuming agsp and plee-the-bear just need headers from bear. (In reply to MartinKG from comment #15) > (In reply to Jeremy Newton from comment #14) > > Package Review > > ============== > > > > Legend: > > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > [ ] = Manual review needed > > > > > > Issues: > > ======= > > - gtk-update-icon-cache is invoked in %postun and %posttrans if package > > contains icons. > > Note: icons in bear-factory > > See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache > > - update-desktop-database is invoked in %post and %postun if package > > contains desktop file(s) with a MimeType: entry. > > Note: desktop file(s) with MimeType entry in bear-factory > > See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop- > > database > > > > done > > > ===== MUST items ===== > > > > C/C++: > > [x]: Package does not contain kernel modules. > > [x]: Package contains no static executables. > > [!]: Development (unversioned) .so files in -devel subpackage, if present. > > Note: Unversioned so-files in private %_libdir subdirectory (see > > attachment). Verify they are not in ld path. > > > See additional comments below > > done, created subpkg devel Well any libraries needed for run-time should be placed into the main package, and any libraries or header/source files needed for build time should be placed into the devel package. (you may have to install the devel headers manually). The unversioned libraries should realistically be fixed upstream IMHO. plee-the-bear and asgp should just BuildRequire the bear-engine-devel package and build without requiring two SOURCE tarballs. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx