https://bugzilla.redhat.com/show_bug.cgi?id=1398949 --- Comment #14 from Jeremy Newton <alexjnewt@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in bear-factory See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in bear-factory See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop- database ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [!]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. > See additional comments below [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (2 clause)", "BSD (2 clause) MIT/X11 (BSD like)", "GPL (v2 or later)", "*No copyright* CC by-sa (v3.0)", "Unknown or generated". 1903 files have unknown license. > The glew code is what's causing it to pick up BSD. I believe this code > SHOULD be removed in prep to make sure it's not compiled or included in > the debug package. This is more of a SHOULD than a MUST though. [!]: License file installed when any subpackage combination is installed. > This is due to a missing require, see "Requires correct" comment to fix it [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/24x24, /usr/share/icons/hicolor/64x64/apps, /usr/share/icons/hicolor/48x48/apps, /usr/share/icons/hicolor/32x32/apps, /usr/share/icons/hicolor/24x24/apps, /usr/share/cmake, /usr/share/icons/hicolor/16x16/apps, /usr/lib64/bear, /usr/share/icons/hicolor/16x16, /usr/share/icons/hicolor/128x128/apps, /usr/share/icons/hicolor/128x128, /usr/share/icons/hicolor/64x64, /usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/bear-factory/item- description/generic/link(plee-the-bear), /usr/share/bear-factory/item- description/generic/system(plee-the-bear), /usr/share/bear- factory/images(plee-the-bear), /usr/share/bear-factory/item- description/generic/expr(plee-the-bear), /usr/share/bear-factory/item- description/generic/forced_movement(plee-the-bear), /usr/share/bear- factory/item-description/generic/script(plee-the-bear), /usr/share /bear-factory/item-description(plee-the-bear), /usr/share/bear-factory /item-description/generic(plee-the-bear), /usr/share/bear-factory /item-description/generic/level_variable(plee-the-bear), /usr/share /bear-factory/item-description/generic/item_brick(plee-the-bear), /usr/share/bear-factory/item-description/generic/game_variable(plee- the-bear), /usr/share/bear-factory(plee-the-bear), /usr/share/bear- factory/item-description/generic/shader(plee-the-bear) > See additional comments below [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [-]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [!]: Package does not generate any conflict. Note: Package contains Conflicts: tag(s) needing fix or justification. > See additional comments below [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. > You need to add the following to bear-factory: > Requires: %{name}-engine%{?_isa} = %{version}-%{release} [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). > See comments inline [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in bear- engine , bear-factory , bear-debuginfo > I've already mentioned this in the "Requires correct" comment [x]: Package functions as described. > I believe so [x]: Latest version is packaged. > Close enough, please use your own discretion here. [x]: Package does not include license text files separate from upstream. > I don't think so, but glew should be removed in prep just in case. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: bear-engine-0.7.0-0.3gitac6be8b.fc25.x86_64.rpm bear-factory-0.7.0-0.3gitac6be8b.fc25.x86_64.rpm bear-debuginfo-0.7.0-0.3gitac6be8b.fc25.x86_64.rpm bear-0.7.0-0.3gitac6be8b.fc25.src.rpm bear-engine.x86_64: W: spelling-error Summary(en_US) Runtime -> Run time, Run-time, Rudiment > Run-time is the correct spelling and should be used bear-engine.x86_64: W: spelling-error %description -l en_US plee -> peel, pee, lee bear-engine.x86_64: W: spelling-error %description -l en_US asgp -> asp, gasp, asap bear-engine.x86_64: W: manual-page-warning /usr/share/man/man6/running-bear.6.gz 5: warning: macro `RS' not defined bear-engine.x86_64: W: manual-page-warning /usr/share/man/man6/running-bear.6.gz 12: warning: macro `RE' not defined bear-factory.x86_64: W: manual-page-warning /usr/share/man/man1/bf-model-editor.1.gz 5: warning: macro `RS' not defined bear-factory.x86_64: W: manual-page-warning /usr/share/man/man1/bf-model-editor.1.gz 12: warning: macro `RE' not defined bear-factory.x86_64: W: manual-page-warning /usr/share/man/man1/bf-level-editor.1.gz 5: warning: macro `RS' not defined bear-factory.x86_64: W: manual-page-warning /usr/share/man/man1/bf-level-editor.1.gz 12: warning: macro `RE' not defined bear-factory.x86_64: W: manual-page-warning /usr/share/man/man1/bf-animation-editor.1.gz 5: warning: macro `RS' not defined bear-factory.x86_64: W: manual-page-warning /usr/share/man/man1/bf-animation-editor.1.gz 12: warning: macro `RE' not defined bear-factory.x86_64: W: no-manual-page-for-binary image-cutter bear-factory.x86_64: W: no-manual-page-for-binary bend-image > I would advice to querying upstream to fix the manpage issues, but this is a "SHOULD" bear.src: W: spelling-error %description -l en_US plee -> peel, pee, lee bear.src: W: spelling-error %description -l en_US asgp -> asp, gasp, asap 4 packages and 0 specfiles checked; 0 errors, 15 warnings. Rpmlint (debuginfo) ------------------- Checking: bear-debuginfo-0.7.0-0.3gitac6be8b.fc25.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- bear-engine.x86_64: W: spelling-error Summary(en_US) Runtime -> Run time, Run-time, Rudiment > Already mentioned above bear-engine.x86_64: W: spelling-error %description -l en_US plee -> peel, pee, lee bear-engine.x86_64: W: spelling-error %description -l en_US asgp -> asp, gasp, asap bear-engine.x86_64: W: manual-page-warning /usr/share/man/man6/running-bear.6.gz 5: warning: macro `RS' not defined bear-engine.x86_64: W: manual-page-warning /usr/share/man/man6/running-bear.6.gz 12: warning: macro `RE' not defined bear-factory.x86_64: W: manual-page-warning /usr/share/man/man1/bf-animation-editor.1.gz 5: warning: macro `RS' not defined bear-factory.x86_64: W: manual-page-warning /usr/share/man/man1/bf-animation-editor.1.gz 12: warning: macro `RE' not defined bear-factory.x86_64: W: manual-page-warning /usr/share/man/man1/bf-level-editor.1.gz 5: warning: macro `RS' not defined bear-factory.x86_64: W: manual-page-warning /usr/share/man/man1/bf-level-editor.1.gz 12: warning: macro `RE' not defined bear-factory.x86_64: W: manual-page-warning /usr/share/man/man1/bf-model-editor.1.gz 5: warning: macro `RS' not defined bear-factory.x86_64: W: manual-page-warning /usr/share/man/man1/bf-model-editor.1.gz 12: warning: macro `RE' not defined bear-factory.x86_64: W: no-manual-page-for-binary image-cutter bear-factory.x86_64: W: no-manual-page-for-binary bend-image > Already mentioned above 3 packages and 0 specfiles checked; 0 errors, 13 warnings. Requires -------- bear-debuginfo (rpmlib, GLIBC filtered): bear-engine (rpmlib, GLIBC filtered): config(bear-engine) libGL.so.1()(64bit) libGLU.so.1()(64bit) libSDL2-2.0.so.0()(64bit) libSDL2_mixer-2.0.so.0()(64bit) libbear_audio.so()(64bit) libbear_communication.so()(64bit) libbear_debug.so()(64bit) libbear_engine.so()(64bit) libbear_expr.so()(64bit) libbear_gui.so()(64bit) libbear_input.so()(64bit) libbear_net.so()(64bit) libbear_text_interface.so()(64bit) libbear_time.so()(64bit) libbear_universe.so()(64bit) libbear_visual.so()(64bit) libboost_filesystem.so.1.60.0()(64bit) libboost_regex.so.1.60.0()(64bit) libboost_system.so.1.60.0()(64bit) libboost_thread.so.1.60.0()(64bit) libc.so.6()(64bit) libclaw_application.so.1()(64bit) libclaw_dynamic_library.so.1()(64bit) libclaw_graphic.so.1()(64bit) libclaw_logger.so.1()(64bit) libclaw_net.so.1()(64bit) libclaw_tween.so.1()(64bit) libdl.so.2()(64bit) libfreetype.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libjpeg.so.62()(64bit) libm.so.6()(64bit) libpng16.so.16()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) bear-factory (rpmlib, GLIBC filtered): config(bear-factory) libbear-editor.so()(64bit) libboost_filesystem.so.1.60.0()(64bit) libboost_system.so.1.60.0()(64bit) libc.so.6()(64bit) libclaw_application.so.1()(64bit) libclaw_configuration_file.so.1()(64bit) libclaw_graphic.so.1()(64bit) libclaw_logger.so.1()(64bit) libclaw_tween.so.1()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libjpeg.so.62()(64bit) libm.so.6()(64bit) libpng16.so.16()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libwx_baseu-2.8.so.0()(64bit) libwx_baseu-2.8.so.0(WXU_2.8)(64bit) libwx_baseu_xml-2.8.so.0()(64bit) libwx_baseu_xml-2.8.so.0(WXU_2.8)(64bit) libwx_gtk2u_adv-2.8.so.0()(64bit) libwx_gtk2u_adv-2.8.so.0(WXU_2.8)(64bit) libwx_gtk2u_core-2.8.so.0()(64bit) libwx_gtk2u_core-2.8.so.0(WXU_2.8)(64bit) libwx_gtk2u_core-2.8.so.0(WXU_2.8.1)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) Provides -------- bear-debuginfo: bear-debuginfo bear-debuginfo(x86-64) bear-engine: bear-engine bear-engine(x86-64) config(bear-engine) libbear_audio.so()(64bit) libbear_communication.so()(64bit) libbear_debug.so()(64bit) libbear_engine.so()(64bit) libbear_expr.so()(64bit) libbear_generic_items.so()(64bit) libbear_gui.so()(64bit) libbear_input.so()(64bit) libbear_net.so()(64bit) libbear_text_interface.so()(64bit) libbear_time.so()(64bit) libbear_universe.so()(64bit) libbear_visual.so()(64bit) bear-factory: application() application(bf-animation-editor.desktop) application(bf-level-editor.desktop) application(bf-model-editor.desktop) bear-factory bear-factory(x86-64) config(bear-factory) libbear-editor.so()(64bit) mimehandler(application/x-bear-animation) mimehandler(application/x-bear-level) mimehandler(application/x-bear-model) Unversioned so-files -------------------- bear-engine: /usr/lib64/bear/libbear_audio.so bear-engine: /usr/lib64/bear/libbear_communication.so bear-engine: /usr/lib64/bear/libbear_debug.so bear-engine: /usr/lib64/bear/libbear_engine.so bear-engine: /usr/lib64/bear/libbear_expr.so bear-engine: /usr/lib64/bear/libbear_generic_items.so bear-engine: /usr/lib64/bear/libbear_gui.so bear-engine: /usr/lib64/bear/libbear_input.so bear-engine: /usr/lib64/bear/libbear_net.so bear-engine: /usr/lib64/bear/libbear_text_interface.so bear-engine: /usr/lib64/bear/libbear_time.so bear-engine: /usr/lib64/bear/libbear_universe.so bear-engine: /usr/lib64/bear/libbear_visual.so bear-factory: /usr/lib64/bear/libbear-editor.so Source checksums ---------------- https://github.com/j-jorge/bear/archive/ac6be8bebf35cd1a4d4151773707c9ee313b154e/bear-ac6be8bebf35cd1a4d4151773707c9ee313b154e.tar.gz#/bear-ac6be8b.tar.gz : CHECKSUM(SHA256) this package : 20e95af49ecd65e4d8511e7fd965782d80cbcfdbdd54f345965ef9fa55246b95 CHECKSUM(SHA256) upstream package : 20e95af49ecd65e4d8511e7fd965782d80cbcfdbdd54f345965ef9fa55246b95 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1398949 Buildroot used: fedora-25-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 Addition Comments ----------------- I'm not opposed to how this is packaged and this should be fine until upstream fixes it, but it's critical that plee-the-bear's maintainers also agree with this, as they need to unbundle it. Furthermore, if everything goes well, you need to make sure that plee-the-bear and bear-* packages are pushed all in one bodhi update, which you will need to collaborate with them on as well. Please see bug #1403607. Also, I can't reproduce the build conflicts issue I was having before, so I'm assuming this was just a mock bug/glitch. I'll make a bug with them if I can figure out how to reproduce it again. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx