https://bugzilla.redhat.com/show_bug.cgi?id=1393899 --- Comment #20 from Ville Skyttä <ville.skytta@xxxxxx> --- It seems to be ok. However, looking at the build log: https://kojipkgs.fedoraproject.org//packages/libdirq/0.4/2.fc26/data/logs/x86_64/build.log > using cflags=-O -DNDEBUG -pedantic -Wall -Wextra -Wshadow -Wpointer-arith -Wcast-align -Wmissing-prototypes -Wmissing-declarations -fpic > [...] > + make -j48 'CFLAGS=-O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -fpic' Looks like the build is now overriding everything in upstream CFLAGS instead of adding the Fedora ones to it. That may have unexpected results; in particular the omission of -DNDEBUG may be a problem. I suggest modifying the build so that it appends RPM_OPT_FLAGS to upstream's default CFLAGS instead of overriding all of them. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
