Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: squeak-vm - Squeak virtual machine for OLPC https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247983 jochen@xxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO AssignedTo|nobody@xxxxxxxxxxxxxxxxx |jochen@xxxxxxxxxxxxxxx ------- Additional Comments From jochen@xxxxxxxxxxxxxxx 2007-07-15 14:59 EST ------- Good: + Package meets naming guidelines + SPEC filename match with package base name + License is MIT + License tag matches with license included in upstream tar ball. + SPEC file is written in English + Package has correct buildroot + Package has not redundant BuildRequires + File list of package doesn't contains duplicates entries + File list contains no files or directories own by other packages Bad. - Don't use Vendor tag - Source tag contains not a full qualified URI - Unnecessary Provide tag - Condition before deleting of the build root is not require - Missing Version entries in the changelog entries - Inproper use of the rpm macros in the %file section - Package doesn't contains a %defattr statemend - Version 3.9-11 seems not to be an official stable version - Package doesn't contains a %doc section - Package doens't contains verbatim copy of the license text, but you can find the license text in the upstream tar ball - Build doesn't use compiler flags in $RPM_OPT_FLAGS - Unnecessary Prefix tag - If you wnat to include all files and directories belang a specific directory, the entry in the file list must ands with a slash - Your package contains file which should be belongs th the nonexisting %doc section - Rpmlint complaints on source rpm: rpmlint squeak-vm-3.9-11olpc3.src.rpm W: squeak-vm hardcoded-prefix-tag %{prefix} W: squeak-vm unversioned-explicit-provides %{name}-%{version} W: squeak-vm setup-not-quiet W: squeak-vm rpm-buildroot-usage %build make ROOT=%{buildroot} %{?_smp_mflags} W: squeak-vm mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 9) - Rpmlint complaints on binary rpm: rpmlint squeak-vm-3.9-11olpc3.x86_64.rpm E: squeak-vm binary-or-shlib-defines-rpath /usr/lib/squeak/3.9-11/squeak ['/usr/lib'] - Mock build failed on Devel (ppc64). Build log will be attached Special question: Do you search a sponsor. If yes, Unfortunately, I can't sponsor you. because I'm not a sponsor. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review