https://bugzilla.redhat.com/show_bug.cgi?id=1402540 --- Comment #5 from Fabio Alessandro Locati <fale@xxxxxxxxxx> --- Thanks Igor :) * Consider taking REAL sources, not the PyPI waste * /usr/libexec -> %{_libexecdir} * /usr/bin -> %{_bindir} * %{python3_sitelib}/gitfame -> %{python3_sitelib}/gitfame/ * %{python3_sitelib}/git_fame-%{version}-py?.?.egg-info -> %{python3_sitelib}/git_fame-*/ Should all be done till here * I think Requires: git is missing (or even git-core, depends what it really requires) Git is actually not required * Consider using Cython version, because it's faster (BR: python3-Cython and --cython to the %py3_build/install executions) Not sure if this would give us real advantages * I would also add Recommends: python3-tabulate In v1.2 is now needed, so I've included as required * Tests are not ran They need some packages that are not present in Fedora (ie: nose-timer) SPEC: https://fale.fedorapeople.org/rpms/git-fame.spec SRPM: https://fale.fedorapeople.org/rpms/git-fame-1.2.0-1.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx