https://bugzilla.redhat.com/show_bug.cgi?id=1359914 --- Comment #28 from MartinKG <mgansser@xxxxxxxx> --- (In reply to Jeremy Newton from comment #27) > (In reply to MartinKG from comment #26) > > The issue of the portal dependency still exists. lollypop should require > lollypop-portal, not the other way around. > > Right now portal has the following requirement: > > Requires: %{name} = %{version}-%{release} > > This should be removed and the following should be added on the base package: > > Requires: %{name}-portal = %{version}-%{release} > > This also allows a user to only install lollypop-portal, if they wish to use > the flatpak instead. done > > As well, is --prefix=/usr should not be used for autogen.sh. I would > personally suggestion running autogen with NOCONFIGURE set, thus to prevent > configure from running, then configure using the %configure macro. > > I'm assuming something like this would work: > > pushd %{subpkg}-%{commit0} > > NOCONFIGURE=1 ./autogen.sh > > %configure > > popd done Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/lollypop.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/lollypop-0.9.223-2.fc25.src.rpm %changelog * Sat Dec 10 2016 Martin Gansser <martinkg@xxxxxxxxxxxxxxxxx> - 0.9.223-2 - Add Requires to base package - Remove Requires on the subpkg lollypop-portal - Add NOCONFIGURE=1 ./autogen.sh to subpkg lollypop-portal -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx