[Bug 1387669] Review Request: kio-gdrive - KDE Dolphin Google Drive access

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1387669



--- Comment #2 from Rex Dieter <rdieter@xxxxxxxxxxxx> ---
You should make clear what items are review blockers, and which are not.  of
those you mentioned, only 5 is a blocker.

The rest, some are only general recommendations (2,4)

For item 4 in particular, those are tailored for autoconf-based projects, and
%make_install in particular misses cmake's nice 'install/fast' target (which is
actually used here, and preferable).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]