[Bug 1402540] Review Request: git-fame - Pretty-print git repository collaborators sorted by contributions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1402540



--- Comment #1 from Raphael Groner <projects.rg@xxxxxxxx> ---
Informal review:

> License:        [MPLv2.0](https://mozilla.org/MPL/2.0/)

Please use License: MPLv2.0
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses

> # https://github.com/casperdcl/git-fame/pull/2
> Source1:        LICENSE.txt
> …
> %files
> %license LICENSE.txt

It's not allowed to maintainers to add their own license. You should wait for
upstream to properly add a license file. I'm not sure if it's allowed to
redistribute MPLv2.0 without a proper license text bundled.
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text

> Requires:       python3-setuptools

Why need setuptools for runtime?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]