https://bugzilla.redhat.com/show_bug.cgi?id=1398369 --- Comment #4 from marcindulak <Marcin.Dulak@xxxxxxxxx> --- Spec URL: https://marcindulak.fedorapeople.org/packages/py-idstools/r02/python-idstools.spec SRPM URL: https://marcindulak.fedorapeople.org/packages/py-idstools/r02/python-idstools-0.5.4-1.fc23.src.rpm (In reply to gil cattaneo from comment #3) > Issues: > > [!]: If (and only if) the source package includes the text of the > license(s) in its own file, then that file, containing the text of the > license(s) for the package is included in %license. I've asked upstream to include a license file https://github.com/jasonish/py-idstools/issues/32 > > [!]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "MIT/X11 (BSD like)", "BSD (2 clause)", "*No copyright* BSD", > "Unknown or generated". 17 files have unknown license. Detailed output > of licensecheck in /home/gil/1398369-python-idstools/licensecheck.txt > Removed the libraries bundled under the compat folder, and with them: MIT/X11 (BSD like) ------------------ py-idstools-0.5.4/idstools/compat/ordereddict.py The setup.py file is explicit about BSD license so there should be no licensing problem for other files > The following source files are without license headers: > py-idstools-0.5.4/bin/idstools-dumpdynamicrules > py-idstools-0.5.4/bin/idstools-eve2pcap > py-idstools-0.5.4/bin/idstools-gensidmsgmap > py-idstools-0.5.4/bin/idstools-rulecat > py-idstools-0.5.4/bin/idstools-u2bench > py-idstools-0.5.4/bin/idstools-u2eve > py-idstools-0.5.4/bin/idstools-u2fast > py-idstools-0.5.4/bin/idstools-u2json > py-idstools-0.5.4/bin/idstools-u2spewfoo > py-idstools-0.5.4/doc/conf.py > py-idstools-0.5.4/idstools/__init__.py > py-idstools-0.5.4/idstools/compat/argparse/argparse.py > py-idstools-0.5.4/idstools/scripts/dumpdynamicrules.py > py-idstools-0.5.4/tests/test_classificationmap.py > py-idstools-0.5.4/tests/test_signaturemap.py > > Please, ask to upstream to confirm the licensing of code and/or content/s, > and add license headers > https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/ > LicensingGuidelines#License_Clarification > > [!]: License file installed when any subpackage combination is installed. see above, we don't have explicit license file yet > > [!]: Package contains no bundled libraries without FPC exception. > py-idstools-0.5.4/idstools/compat/argparse/__init__.py > py-idstools-0.5.4/idstools/compat/argparse/argparse.py > py-idstools-0.5.4/idstools/compat/argparse/LICENSE.txt addressed above > > [!]: If the source package does not include license text(s) as a separate > file from upstream, the packager SHOULD query upstream to include it. see above > > [!]: Package does not include license text files separate from upstream. > > [!]: Package consistently uses macros (instead of hard-coded directory > names). > > "%{!?py2_build: %global py2_build CFLAGS="%{optflags}" /usr/bin/python2 > setup.py build --executable="/usr/bin/python2 -s"}" > > [?]: Package complies to the Packaging Guidelines > why customized the py?_build/install macros? I've removed the macros. Without those macros the RPM does not build on a standalone CentOS7, but it builds in koji and mock. > > Please, fix these problems > > python3-idstools.noarch: E: wrong-script-interpreter > /usr/lib/python3.5/site-packages/idstools/scripts/rulecat.py /usr/bin/env > python > python3-idstools.noarch: E: non-executable-script > /usr/lib/python3.5/site-packages/idstools/scripts/rulecat.py 644 > /usr/bin/env python > python3-idstools.noarch: E: wrong-script-interpreter > /usr/lib/python3.5/site-packages/idstools/scripts/gensidmsgmap.py > /usr/bin/env python > python3-idstools.noarch: E: non-executable-script > /usr/lib/python3.5/site-packages/idstools/scripts/gensidmsgmap.py 644 > /usr/bin/env python > python3-idstools.noarch: E: wrong-script-interpreter > /usr/lib/python3.5/site-packages/idstools/scripts/u2eve.py /usr/bin/env > python > python3-idstools.noarch: E: non-executable-script > /usr/lib/python3.5/site-packages/idstools/scripts/u2eve.py 644 /usr/bin/env > python > python3-idstools.noarch: E: wrong-script-interpreter > /usr/lib/python3.5/site-packages/idstools/scripts/u2fast.py /usr/bin/env > python > python3-idstools.noarch: E: non-executable-script > /usr/lib/python3.5/site-packages/idstools/scripts/u2fast.py 644 /usr/bin/env > python > python3-idstools.noarch: E: wrong-script-interpreter > /usr/lib/python3.5/site-packages/idstools/scripts/u2spewfoo.py /usr/bin/env > python > python3-idstools.noarch: E: non-executable-script > /usr/lib/python3.5/site-packages/idstools/scripts/u2spewfoo.py 644 > /usr/bin/env python > python3-idstools.noarch: E: wrong-script-interpreter > /usr/lib/python3.5/site-packages/idstools/scripts/eve2pcap.py /usr/bin/env > python > python3-idstools.noarch: E: non-executable-script > /usr/lib/python3.5/site-packages/idstools/scripts/eve2pcap.py 644 > /usr/bin/env python > python3-idstools.noarch: E: wrong-script-interpreter > /usr/lib/python3.5/site-packages/idstools/scripts/u2json.py /usr/bin/env > python > python3-idstools.noarch: E: non-executable-script > /usr/lib/python3.5/site-packages/idstools/scripts/u2json.py 644 /usr/bin/env > python > I remove the python shabang from those files during %build, and reported this at https://github.com/jasonish/py-idstools/issues/33 > NON blocking issues: > python3-idstools.noarch: W: no-manual-page-for-binary idstools-u2fast > python3-idstools.noarch: W: no-manual-page-for-binary idstools-eve2pcap > python3-idstools.noarch: W: no-manual-page-for-binary idstools-u2eve > python3-idstools.noarch: W: no-manual-page-for-binary idstools-gensidmsgmap > python3-idstools.noarch: W: no-manual-page-for-binary idstools-rulecat > python3-idstools.noarch: W: no-manual-page-for-binary idstools-u2json > > manual pages should be generated with sphinx in py-idstools-0.5.4/doc ? let's drop building the documentation with sphinx and adding the -doc packages, for at least two reasons: 1. cd doc&& make man creates rather ugly idstools.1 idstools-rulecat.1, there is some structure in those but they look mostly like parsing of doc strings. 2. python34-sphinxcontrib-programoutput needed for a sphinx run is not available on EPEL7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx