https://bugzilla.redhat.com/show_bug.cgi?id=1401344 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |tcallawa@xxxxxxxxxx Flags| |fedora-review? --- Comment #2 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> --- At some point, the lulzbot fork will move to the current cura version, but this makes sense for now. = Review = - rpmlint returns: CuraEngine-lulzbot.src: E: description-line-too-long C CuraEngine-lulzbot is a C++ console application for 3D printing G-code generation. It CuraEngine-lulzbot.src: E: description-line-too-long C application look at cura-lulzbot with is the graphical frontend for CuraEngine-lulzbot. CuraEngine-lulzbot.src:11: W: macro-in-comment %{name} CuraEngine-lulzbot.src:11: W: macro-in-comment %{version} These are all easily fixed, please do it. (There are other rpmlint warnings emitted, but they are all safe to ignore). - package meets naming guidelines - package meets packaging guidelines - license (AGPLv3) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Fix the rpmlint issues and I'll approve. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx