[Bug 1359402] Review Request: coot - crystallographic macromolecular building toolkit (unretire request )

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1359402



--- Comment #28 from Tim Fenn <tim.fenn@xxxxxxxxx> ---
(In reply to Antonio Trande from comment #27)
> Created attachment 1221971 [details]
> review log
> 
> Package Review
> ==============
> 
> Legend:
> [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> [ ] = Manual review needed
> 
> 
> Issues:
> =======
> 
> - ----> sed -i -e 's! -shared ! -Wl,--as-needed\0!g' libtool <-----
> 
> This commands does not work.
> Try to set LDFLAGS="$RPM_LD_FLAGS -Wl,--as-needed"
> 

Can't get this to work - part of the problem is many of these dependencies are
pulled in using pkg-config, so there isn't a simple solution that I can think
of/come up with.  Any suggestions?

> - undefined-non-weak-symbol warnings appears on rawhide only; something is
> changed in new release
> (see rpmlint output). Please ask to upstream.
> 

This is straightforward to fix, but I'm more concerned about how to handle the
shlib issue?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]