https://bugzilla.redhat.com/show_bug.cgi?id=1400236 --- Comment #4 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- (In reply to Dhanesh B. Sabane from comment #3) > (In reply to Zbigniew Jędrzejewski-Szmek from comment #2) > > Why? > So that consistency is maintained. As far as I know, one of the > requirements of a good package is that it consistently uses macros. Not really. The guidelines say that macros should be used for directory names [1] (and it's "should", not "must", there are various exceptions) and some binaries. Replacing every instance of the package name with a macro just makes it harder to copy&paste the text, or to click on a link to open it, etc. [1] https://fedoraproject.org/wiki/Packaging:Guidelines#Macros > python-podcastparser.src: W: invalid-url Source0: > https://github.com/gpodder/podcastparser/archive/v0.6.0.tar.gz#/ Ah, the "v" shouldn't be there. Source0 should be %{url}/archive/%{version}.tar.gz#/%{modname}-%{version}.tar.gz -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx