https://bugzilla.redhat.com/show_bug.cgi?id=1395244 Randy Barlow <randy@xxxxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aurelien@xxxxxxxxxxx Flags| |needinfo?(aurelien@bompard. | |org) --- Comment #1 from Randy Barlow <randy@xxxxxxxxxxxxxxxxxxxxx> --- I only found one thing we would need to fix to approve this: * fedora-review thinks that COPYRIGHT.txt should be marked as %license, even though there's also a LICENSE.txt. I personally think it might be OK as is, but it also makes some sense for copyright and license to be together so I think it would be a good thing to fix. This is an optional suggestion, so you can ignore if you want: * The package defines srcname and pkgname. It would be cleaner to just use one or the other of those two instead of both. Question for my own knowledge: * What are the python3_other macros? Are those standard macros, or are they used when doing manual builds? I've not seen them before. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx