https://bugzilla.redhat.com/show_bug.cgi?id=1396232 --- Comment #5 from Phil Sutter <psutter@xxxxxxxxxx> --- Hi Igor, (In reply to Igor Gnatenko from comment #4) > * BuildRequires: git -> BuildRequires: git-core > git itself requires a lot of perl which you don't really need to apply > patches. > * %autosetup -S git > probably you just want %autosetup -p1 to not pull git into BuildRequires Ah yes, that is much easier. When playing around with autosetup options, I got errors during patch applying, but probably that was just due to missing '-p1' option. > * %doc LICENSE README > LICENSE should be %license, READNE should be %doc > * Also put comment where you sent patches to upstream (or why you didn't > sent)... OK, DONE! Here are updated URLs for review: Spec URL: https://psutter.fedorapeople.org/libkeepalive.spec SRPM URL: https://psutter.fedorapeople.org/libkeepalive-0.3-3.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx