https://bugzilla.redhat.com/show_bug.cgi?id=1386938 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Blocks|177841 (FE-NEEDSPONSOR) | Flags|fedora-review? |fedora-review+ --- Comment #19 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- fedora-review says: - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/lib64/perl5/vendor_perl/auto/Prelude/Prelude.so See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles (Use "%dir %{perl_vendorarch}/auto/Prelude") fedora-review has some other complaints, but they are invalid afaict. Rpmlint ------- Checking: libprelude-3.1.0-26.fc26.x86_64.rpm libprelude-devel-3.1.0-26.fc26.x86_64.rpm prelude-tools-3.1.0-26.fc26.x86_64.rpm python2-prelude-3.1.0-26.fc26.x86_64.rpm python3-prelude-3.1.0-26.fc26.x86_64.rpm perl-prelude-3.1.0-26.fc26.x86_64.rpm ruby-prelude-3.1.0-26.fc26.x86_64.rpm lua-prelude-3.1.0-26.fc26.x86_64.rpm libprelude-doc-3.1.0-26.fc26.noarch.rpm libprelude-debuginfo-3.1.0-26.fc26.x86_64.rpm libprelude-3.1.0-26.fc26.src.rpm libprelude.x86_64: W: crypto-policy-non-compliance-gnutls-2 /usr/lib64/libprelude.so.23.3.0 gnutls_priority_init prelude-tools.x86_64: W: crypto-policy-non-compliance-gnutls-1 /usr/bin/prelude-admin gnutls_priority_set_direct This is probably a bug in the rpmlint checker. libprelude-devel.x86_64: W: only-non-binary-in-usr-lib prelude-tools.x86_64: W: spelling-error Summary(en_US) libprelude -> lib prelude, lib-prelude, prelude prelude-tools.x86_64: W: no-manual-page-for-binary prelude-adduser python2-prelude.x86_64: W: no-documentation python3-prelude.x86_64: W: no-documentation perl-prelude.x86_64: W: no-documentation ruby-prelude.x86_64: W: no-documentation lua-prelude.x86_64: W: no-documentation libprelude-doc.noarch: W: spelling-error %description -l en_US gtk -> gt, gt k 11 packages and 0 specfiles checked; 0 errors, 11 warnings. All OK. + package name is OK + license is ACCEPTABLE (various variants of GPL) - license is specified correctly (see below) + builds and installs OK + P/R/BR look correct + scriptlets look OK + %check is present and passes The license tag is not correct though: the license tag applies to the *binary* rpms [https://fedoraproject.org/wiki/Licensing:FAQ?rd=Licensing/FAQ#Does_the_License:_tag_cover_the_SRPM_or_the_binary_RPM.3F, https://fedoraproject.org/wiki/Licensing:FAQ?rd=Licensing/FAQ#What_is_.22effective_license.22_and_do_I_need_to_know_that_for_the_License:_tag.3F]. In this case: # libmissing is LGPL-2.1+ → built as part of the final product, compatible with GPL # libmissing/test is GPL-3.0+ → can be ignored, because this is not distributed as part of the binary rpm # Prelude is GPL-2.0+ → This is the effective license Build fails in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=16709324, on arm64 this time. The error doesn't look to bad, but it's most likely an upstream issue, so I think it's fine if you use ExcludeArch until it's fixed. prelude-log.c: In function 'do_log_v': prelude-log.c:51:50: error: incompatible type for argument 1 of 'memmove' # define PRELUDE_VA_COPY(ap1, ap2) memmove ((ap1), (ap2), sizeof(va_list)) ^ prelude-log.c:229:9: note: in expansion of macro 'PRELUDE_VA_COPY' PRELUDE_VA_COPY(bkp, ap); ^~~~~~~~~~~~~~~ In file included from /usr/include/features.h:397:0, from /usr/include/sys/types.h:25, from ../libmissing/sys/types.h:28, from ../libmissing/ftw_.h:20, from ./include/libmissing.h:34, from prelude-log.c:24: /usr/include/bits/string3.h:57:1: note: expected 'void *' but argument is of type 'va_list {aka __va_list}' __NTH (memmove (void *__dest, const void *__src, size_t __len)) ^ prelude-log.c:51:57: error: incompatible type for argument 2 of 'memmove' # define PRELUDE_VA_COPY(ap1, ap2) memmove ((ap1), (ap2), sizeof(va_list)) ^ prelude-log.c:229:9: note: in expansion of macro 'PRELUDE_VA_COPY' PRELUDE_VA_COPY(bkp, ap); ^~~~~~~~~~~~~~~ In file included from /usr/include/features.h:397:0, from /usr/include/sys/types.h:25, from ../libmissing/sys/types.h:28, from ../libmissing/ftw_.h:20, from ./include/libmissing.h:34, from prelude-log.c:24: /usr/include/bits/string3.h:57:1: note: expected 'const void *' but argument is of type 'va_list {aka __va_list}' __NTH (memmove (void *__dest, const void *__src, size_t __len)) ^ OK, so we have two simple issues (repeated file, license), and the failing builds on more exotic architectures. You said it built for you, but did you use the rawhide koji which has more architectures enabled? The failure looks deterministic. Looks very nice otherwise. Package is APPROVED. Please fix up the remaining issues when uploading. -- I've added you to the packagers group. Have fun, use your powers for good, etc ;) If you have any questions I'm always happy to help (the bugzilla e-mail or zbyszek on #fedora-devel). Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx