[Bug 1376783] Review Request: python-can: The can package provides controller area network support for Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1376783



--- Comment #4 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
> All of the above is a matter of opinion and hence the choice of the maintainer.

Sure, this was just a suggestion. I do think it makes life easier (certainly
for
a reviewer, but I think also for the maintainer).

The license is specified incorrectly: it's LGPLv3+ according to the LICENSE
file.

rpmlint:
python2-can.noarch: E: script-without-shebang /usr/bin/j1939_logger.py
python2-can.noarch: E: wrong-script-interpreter
/usr/lib/python2.7/site-packages/can/util.py /usr/bin/env python3
python2-can.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/can/util.py 644 /usr/bin/env python3
python2-can.noarch: E: wrong-script-interpreter
/usr/lib/python2.7/site-packages/can/broadcastmanager.py /usr/bin/env python3
python2-can.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/can/broadcastmanager.py 644 /usr/bin/env
python3

At least the first should be fixed.

Requires
--------
python2-can (rpmlib, GLIBC filtered):
    /usr/bin/python3 <--------------- this looks wrong
    python(abi)

Provides
--------
python3-can:
    python-can <-------------------- this looks wrong
    python3-can
    python3.5dist(python-can)
    python3dist(python-can)

Oh, it's a typo in python_provide for the py3 subpackage.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]