[Bug 1389971] Review Request: elemental - distributed-memory dense and sparse-direct linear algebra and optimizatio

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1389971



--- Comment #33 from Antonio Trande <anto.trande@xxxxxxxxx> ---
>Should I just excludearch them as well?

No.
I thought you wanted to compile on epel, too.

The review is almost done:

- Your are not using %license to pack the license files.

- You should use %doc or %_pkgdocdir macros for documentation, not
%{_docdir}/Elemental
(http://fedoraproject.org/wiki/Packaging:Guidelines#Documentation):

$ rpm --eval %_pkgdocdir
%{_docdir}/%{name}

- 'elemental-common' provides arch-independent files, so it is a 'noarch'
package.
Please, modify in this sense

%package common
Summary: Files in common between mpich and openmpi
Group: Development/Libraries
BuildArch: noarch                         <---
Requires: qt5-qtbase
%description common 
Files not specific to mpich or openmpi

Consequently, other packages which require 'elemental-common' use the line

Requires: %{name}-common = %{version}-%{release}

(without '%{?_isa}')

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]