https://bugzilla.redhat.com/show_bug.cgi?id=1399648 --- Comment #5 from Petr <mpv@xxxxxxxxxxxx> --- I checked official src, rebuilt in mock for el7.centos https://kojipkgs.fedoraproject.org//packages/xl2tpd/1.3.8/1.fc26/src/xl2tpd-1.3.8-1.fc26.src.rpm Rpmlint xl2tpd.src:55: W: setup-not-quiet xl2tpd.src:74: E: hardcoded-library-path in %{_prefix}/lib/tmpfiles.d/ xl2tpd.src:75: E: hardcoded-library-path in %{_prefix}/lib/tmpfiles.d/%{name}.conf xl2tpd.src:113: E: hardcoded-library-path in %{_prefix}/lib/tmpfiles.d/%{name}.conf xl2tpd.src: W: invalid-url Source0: https://github.com/xelerance/xl2tpd/archive/xl2tpd-1.3.8.tar.gz HTTP Error 404: Not Found xl2tpd.x86_64: W: incoherent-version-in-changelog 1.3.8-1 ['1.3.8-1.el7.centos', '1.3.8-1.centos'] xl2tpd.x86_64: W: only-non-binary-in-usr-lib xl2tpd.x86_64: E: non-readable /etc/xl2tpd/l2tp-secrets 0600L xl2tpd.x86_64: E: incorrect-fsf-address /usr/share/doc/xl2tpd-1.3.8/LICENSE xl2tpd.x86_64: E: non-readable /var/run/xl2tpd/l2tp-control 0600L xl2tpd.x86_64: E: non-readable /etc/ppp/chap-secrets.sample 0600L xl2tpd.x86_64: W: no-manual-page-for-binary xl2tpd-control 3 packages and 0 specfiles checked; 7 errors, 5 warnings. spec: incorrect global commit, should be global commit cec1ebe1523bf248f134647dd6030a333d93e19b # upstream isn't using proper names, we manually rename v-VERSION.tar.gz to xl2tpd-VERSION.tar.gz Source0: https://github.com/xelerance/%{name}/archive/%{name}-%{version}.tar.gz Also contains your marked moments Besides inline comments(marked with yunying:), here are some additional: 1. "Group:" is not needed. 2. "rm -rf %{buildroot}" should be removed. 3. replace following "xl2tpd" in SPEC file with "%name". yunying: LICENSE file contains text of license itself, so should be put under "%license". > yunying: use "%make_build" instead of "make". > yunying: use %{_libdir} instead of hardcoded-library-path. How did they pass?? -- I requested for LICENSE -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx