https://bugzilla.redhat.com/show_bug.cgi?id=1369720 --- Comment #18 from Yunying Sun <yunying.sun@xxxxxxxxx> --- (run a fedora-review over this package myself) Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc gcc-c++ See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "BSD (2 clause)". Detailed output of licensecheck in /home/test/yunyings/rpmreview/1369720_tpm2-tools /review-tpm2-tools/licensecheck.txt [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/sbin, /usr/share/doc, /usr/share/licenses, /usr/share, /usr [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 1.2.21 starting (python version = 2.7.5)... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled yum cache Start: cleaning yum metadata Finish: cleaning yum metadata Mock Version: 1.2.21 INFO: Mock Version: 1.2.21 Finish: chroot init INFO: installing package(s): /home/test/yunyings/rpmreview/1369720_tpm2-tools/review-tpm2-tools/results/tpm2-tools-1.1.0-1.el7.centos.x86_64.rpm /home/test/yunyings/rpmreview/1369720_tpm2-tools/review-tpm2-tools/results/tpm2-tools-debuginfo-1.1.0-1.el7.centos.x86_64.rpm ERROR: Command failed. See logs for output. # /usr/bin/yum --installroot /var/lib/mock/epel-7-x86_64/root/ --releasever 7 install /home/test/yunyings/rpmreview/1369720_tpm2-tools/review-tpm2-tools/results/tpm2-tools-1.1.0-1.el7.centos.x86_64.rpm /home/test/yunyings/rpmreview/1369720_tpm2-tools/review-tpm2-tools/results/tpm2-tools-debuginfo-1.1.0-1.el7.centos.x86_64.rpm --setopt=tsflags=nocontexts Rpmlint ------- Checking: tpm2-tools-1.1.0-1.el7.centos.x86_64.rpm tpm2-tools-1.1.0-1.el7.centos.src.rpm tpm2-tools.x86_64: W: summary-not-capitalized C a TPM2.0 testing tool build upon TPM2.0-TSS tpm2-tools.x86_64: W: incoherent-version-in-changelog 1.1.0-1 ['1.1.0-1.el7.centos', '1.1.0-1.centos'] tpm2-tools.x86_64: W: no-manual-page-for-binary tpm2_quote tpm2-tools.x86_64: W: no-manual-page-for-binary tpm2_nvdefine tpm2-tools.x86_64: W: no-manual-page-for-binary tpm2_nvwrite tpm2-tools.x86_64: W: no-manual-page-for-binary tpm2_hmac tpm2-tools.x86_64: W: no-manual-page-for-binary tpm2_unseal tpm2-tools.x86_64: W: no-manual-page-for-binary tpm2_makecredential tpm2-tools.x86_64: W: no-manual-page-for-binary tpm2_evictcontrol tpm2-tools.x86_64: W: no-manual-page-for-binary tpm2_nvreadlock tpm2-tools.x86_64: W: no-manual-page-for-binary tpm2_certify tpm2-tools.x86_64: W: no-manual-page-for-binary tpm2_getmanufec tpm2-tools.x86_64: W: no-manual-page-for-binary tpm2_akparse tpm2-tools.x86_64: W: no-manual-page-for-binary tpm2_nvlist tpm2-tools.x86_64: W: no-manual-page-for-binary tpm2_sign tpm2-tools.x86_64: W: no-manual-page-for-binary tpm2_nvread tpm2-tools.x86_64: W: no-manual-page-for-binary tpm2_takeownership tpm2-tools.x86_64: W: no-manual-page-for-binary tpm2_create tpm2-tools.x86_64: W: no-manual-page-for-binary tpm2_readpublic tpm2-tools.x86_64: W: no-manual-page-for-binary tpm2_verifysignature tpm2-tools.x86_64: W: no-manual-page-for-binary tpm2_getpubek tpm2-tools.x86_64: W: no-manual-page-for-binary tpm2_load tpm2-tools.x86_64: W: no-manual-page-for-binary tpm2_encryptdecrypt tpm2-tools.x86_64: W: no-manual-page-for-binary tpm2_listpersistent tpm2-tools.x86_64: W: no-manual-page-for-binary tpm2_getrandom tpm2-tools.x86_64: W: no-manual-page-for-binary tpm2_getpubak tpm2-tools.x86_64: W: no-manual-page-for-binary tpm2_hash tpm2-tools.x86_64: W: no-manual-page-for-binary tpm2_createprimary tpm2-tools.x86_64: W: no-manual-page-for-binary tpm2_nvrelease tpm2-tools.x86_64: W: no-manual-page-for-binary tpm2_loadexternal tpm2-tools.x86_64: W: no-manual-page-for-binary tpm2_rc_decode tpm2-tools.x86_64: W: no-manual-page-for-binary tpm2_rsaencrypt tpm2-tools.x86_64: W: no-manual-page-for-binary tpm2_listpcrs tpm2-tools.x86_64: W: no-manual-page-for-binary tpm2_rsadecrypt tpm2-tools.x86_64: W: no-manual-page-for-binary tpm2_activatecredential tpm2-tools.src: W: summary-not-capitalized C a TPM2.0 testing tool build upon TPM2.0-TSS tpm2-tools.src: W: strange-permission tpm2-tools.spec 0775L tpm2-tools.src:6: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 6) 2 packages and 0 specfiles checked; 0 errors, 38 warnings. Requires -------- tpm2-tools (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcrypto.so.10()(64bit) libcrypto.so.10(libcrypto.so.10)(64bit) libcurl.so.4()(64bit) libgcc_s.so.1()(64bit) libm.so.6()(64bit) libsapi.so.0()(64bit) libstdc++.so.6()(64bit) libtcti-device.so.0()(64bit) libtcti-socket.so.0()(64bit) rtld(GNU_HASH) tpm2-tss Provides -------- tpm2-tools: tpm2-tools tpm2-tools(x86-64) Source checksums ---------------- https://github.com/01org/tpm2.0-tools/archive/v1.1.0.tar.gz#/tpm2.0-tools-1.1.0.tar.gz : CHECKSUM(SHA256) this package : 66c5b73a04f96bf6f7e68c0ed5a2320f1ccc73b61c67428ba802ff0940f374d0 CHECKSUM(SHA256) upstream package : 66c5b73a04f96bf6f7e68c0ed5a2320f1ccc73b61c67428ba802ff0940f374d0 Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04 Command line :/usr/bin/fedora-review -n tpm2-tools Buildroot used: epel-7-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx