Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pixie - 3D renderer Renderman compliant https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241549 ------- Additional Comments From lxtnow@xxxxxxxxx 2007-07-14 00:48 EST ------- === REQUIRED ITEMS === [ FAILED ] Package is named according to the Package Naming Guidelines. [ FAILED ] Spec file name must match the base package name. [ OK ] Package meets the Packaging Guidelines. [ OK ] Package successfully builds into binary rpms on at least one supported architecture. [ CHECK ] Tested on: Mock i386 [FC-devel] [ OK ] Package is not relocatable. [ OK ] Buildroot is correct [ OK ] Package is licensed with an open-source compatible license. [ Ok ] License field in the package spec file matches the actual license. [ OK ] License type: LGPL [ OK ] The source package includes the text of the license(s). [ OK ] Spec file is legible and written in American English. [ OK ] Package is not known to require ExcludeArch. [ OK ] All build dependencies are listed in BuildRequires. [ CHECK ] The spec file handles locales properly. [ OK ] ldconfig called in %post and %postun if required. [ ? ] Package must own all directories that it creates. [ OK ] Package requires other packages for directories it uses. [ OK ] Package does not contain duplicates in %files. [ Ok ] Permissions on files are set properly. [ OK ] Package has a %clean section. [ OK ] Package consistently uses macros. [ OK ] Package contains code, or permissable content. [ ? ] Large documentation files are in a -doc subpackage, if required. [ ? ] Package uses nothing in %doc for runtime. [ SKIP ] Header files in -devel subpackage, if present. [ SKIP ] Static libraries in -devel subpackage, if present. [ SKIP ] Package requires pkgconfig, if .pc files are present. [ Ok ] Development .so files in -devel subpackage, if present. [ Ok ] Fully versioned dependency in subpackages, if present. [ OK ] Package does not contain any libtool archives (.la). [ SKIP ] Package contains a properly installed %{name}.desktop file. [ OK ] Package does not own files or directories owned by other packages. [ CHECK ] Requires: libGL.so.1()(64bit) libGLU.so.1()(64bit) libHalf.so.4()(64bit) libIex.so.4()(64bit) libIlmImf.so.4()(64bit) libImath.so.4()(64bit) libX11.so.6()(64bit) libXext.so.6()(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit) libdl.so.2()(64bit) libdl.so.2(GLIBC_2.2.5)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libm.so.6(GLIBC_2.2.5)(64bit) libpixiecommon.so.0()(64bit) libpthread.so.0()(64bit) libpthread.so.0(GLIBC_2.2.5)(64bit) libri.so.0()(64bit) libsdr.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(GLIBCXX_3.4)(64bit) libtiff.so.3()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) === ISSUES === # Package Name: The base package name is Pixie (with upper-case letter). Please move it to Pixie instead of pixie. That's also imply to move the name of spec file to the right one. # Timestamps action: This package have many text/documentations files and png/icons files so keeping timestamps is desirable. Does this package accept 'make INSTALL="install -p" install' ? # Some concerns about Large documentation: The final package is mostly documentation.I don't think it's mandatory that it be split into a -doc subpackage. But, it'll be not a bad idea to do so. Also, any reason to mkdir'ed __doc (with double underscore) ? # Ownership: Currently your %file section (main package) sound good. however, i've some comment about ownership (which can be improved). ---------- %dir %{_libdir}/Pixie %{_libdir}/Pixie/displays/ %{_libdir}/Pixie/modules/ ---------- The use of %{_libdir}/Pixie is enough and owned by the package (including sub-folders) ---------- %dir %{_datadir}/Pixie %dir %{_datadir}/Pixie/shaders %{_datadir}/Pixie/shaders/*.sdr %{_datadir}/Pixie/shaders/*.sl ---------- You don't need to own sub-folders if you already own parent directory. And, As above, this can be improved by %{_datadir}/Pixie (which's enough to be owned) # Quick request: Nicolas, will you upload somewhere the packaged x86_64 binaries please ? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review