https://bugzilla.redhat.com/show_bug.cgi?id=1324020 --- Comment #31 from gil cattaneo <puntogil@xxxxxxxxx> --- Issues: [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Apache (v2.0) BSD (3 clause)", "Unknown or generated", "*No copyright* Apache (v2.0)". 74 files have unknown license. Detailed output of licensecheck in /home/gil/1324020-cassandra/licensecheck.txt Apache (v2.0) BSD (3 clause) cassandra-3.9/src/java/org/apache/cassandra/utils/vint/VIntCoding.java [!]: License file installed when any subpackage combination is installed. Missing NOTICE.txt in javadoc sub package The following source files are without license headers: cassandra-3.9/doc/source/_static/extra.css cassandra-3.9/src/java/org/apache/cassandra/db/commitlog/IntervalSet.java cassandra-3.9/src/java/org/apache/cassandra/utils/IntegerInterval.java cassandra-3.9/test/unit/org/apache/cassandra/db/commitlog/CommitLogCQLTest.java cassandra-3.9/test/unit/org/apache/cassandra/utils/IntegerIntervalsTest.java cassandra-3.9/tools/stress/src/org/apache/cassandra/stress/WorkManager.java cassandra-3.9/tools/stress/src/org/apache/cassandra/stress/util/TimingIntervals.java Please, contact upstream and ask to confirm the licensing of code and/or content/s, and add license headers https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Clarification > (In reply to gil cattaneo from comment #28) > > A question: > > ... > > install -p -D -m 755 build/tools/lib/%{pkg_name}-stress.jar > > %{buildroot}%{_javadir}/%{pkg_name}-stress.jar > > ... > > %attr(755, root, root) %{_javadir}/%{pkg_name}-stress.jar > > > > why? > > should be > > install -p -D -m 644 build/tools/lib/%{pkg_name}-stress.jar > %{buildroot}%{_javadir}/%{pkg_name}/%{pkg_name}-stress.jar > > %{_javadir}/%{pkg_name}/%{pkg_name}-stress.jar https://fedoraproject.org/wiki/Packaging:Java#JAR_file_installation Not available "macros to handle systemd scriptlet operations" https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#Systemd [!]: Requires correct, justified where necessary. Please, remove useless: %{?scl:Requires: %scl_require rh-maven33} [!]: Packages are noarch unless they use JNI Note: cassandra subpackage is not noarch. Please verify manually -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx