https://bugzilla.redhat.com/show_bug.cgi?id=1375765 Randy Barlow <randy@xxxxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #10 from Randy Barlow <randy@xxxxxxxxxxxxxxxxxxxxx> --- Looks good, nice work! Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "ISC", "MIT/X11 (BSD like)", "LGPL (v2.1 or later)", "GPL (v3 or later)", "Unknown or generated". 573 files have unknown license. Detailed output of licensecheck in /home/rbarlow/reviews/yosys/licensecheck.txt [-]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in yosys- doc , yosys-share , yosys-devel , yosys-debuginfo [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 3194880 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: yosys-0.7-1.fc26.x86_64.rpm yosys-doc-0.7-1.fc26.x86_64.rpm yosys-share-0.7-1.fc26.noarch.rpm yosys-devel-0.7-1.fc26.x86_64.rpm yosys-debuginfo-0.7-1.fc26.x86_64.rpm yosys-0.7-1.fc26.src.rpm yosys.x86_64: W: name-repeated-in-summary C Yosys yosys-share.noarch: W: no-documentation yosys.src: W: name-repeated-in-summary C Yosys yosys.src:1: W: macro-in-comment %global yosys.src:3: W: macro-in-comment %global yosys.src:3: W: macro-in-comment %{commit0} yosys.src:10: W: macro-in-comment %{shortcommit0} yosys.src:16: W: macro-in-comment %{name} yosys.src:16: W: macro-in-comment %{commit0} yosys.src:88: W: macro-in-comment %setup yosys.src:88: W: macro-in-comment %{name} yosys.src:88: W: macro-in-comment %{commit0} yosys.src:98: W: macro-in-comment %setup yosys.src:98: W: macro-in-comment %{name} yosys.src:98: W: macro-in-comment %{commit0} 6 packages and 0 specfiles checked; 0 errors, 15 warnings. Rpmlint (debuginfo) ------------------- Checking: yosys-debuginfo-0.7-1.fc26.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- yosys.x86_64: W: name-repeated-in-summary C Yosys yosys-share.noarch: W: no-documentation 5 packages and 0 specfiles checked; 0 errors, 2 warnings. Requires -------- yosys-devel (rpmlib, GLIBC filtered): /bin/bash yosys(x86-64) yosys (rpmlib, GLIBC filtered): /usr/bin/python3 abc graphviz libc.so.6()(64bit) libdl.so.2()(64bit) libffi.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libreadline.so.6()(64bit) librt.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libtcl8.6.so()(64bit) python-xdot rtld(GNU_HASH) yosys-share yosys-doc (rpmlib, GLIBC filtered): yosys-share (rpmlib, GLIBC filtered): yosys-debuginfo (rpmlib, GLIBC filtered): Provides -------- yosys-devel: yosys-devel yosys-devel(x86-64) yosys: yosys yosys(x86-64) yosys-doc: yosys-doc yosys-doc(x86-64) yosys-share: yosys-share yosys-debuginfo: yosys-debuginfo yosys-debuginfo(x86-64) Source checksums ---------------- http://http.debian.net/debian/pool/main/y/yosys/yosys_0.7-2.debian.tar.xz : CHECKSUM(SHA256) this package : ea89aa745fcd82de994b05cd37d14b255dc6cbd4972b5c33d8e47260e15b2918 CHECKSUM(SHA256) upstream package : ea89aa745fcd82de994b05cd37d14b255dc6cbd4972b5c33d8e47260e15b2918 https://github.com/cliffordwolf/yosys/archive/yosys-0.7.tar.gz : CHECKSUM(SHA256) this package : 3df986d0c6bf20b78193456e11c660f2ad935cc126537c2dc5726e78896d6e6e CHECKSUM(SHA256) upstream package : 3df986d0c6bf20b78193456e11c660f2ad935cc126537c2dc5726e78896d6e6e https://github.com/mdaines/viz.js/releases/download/0.0.3/viz.js : CHECKSUM(SHA256) this package : 0eb4139c4a6067e73585338e32e9f7515490edd885d16147322a48e43b120012 CHECKSUM(SHA256) upstream package : 0eb4139c4a6067e73585338e32e9f7515490edd885d16147322a48e43b120012 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -rn yosys-0.7-1.fc24.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx