https://bugzilla.redhat.com/show_bug.cgi?id=1312301 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- (In reply to Jitka Plesnikova from comment #2) > BuildRequires > FIX: Please add following BRs: > - make > - perl > - perl-generators +BuildRequires: perl +BuildRequires: perl-generators ... +BuildRequires: %{__make} Ok. > FIX: Binary requires and provides are not complete due to missing BR > perl-generators $ rpm -qp --requires perl-Net-LDAP-Server-0.43-2.fc26.noarch.rpm | sort | uniq -c 1 perl(:MODULE_COMPAT_5.24.0) 1 perl(Convert::ASN1) 1 perl(Data::Dumper) 1 perl(Net::LDAP::ASN) 1 perl(Net::LDAP::Constant) 1 perl(Net::LDAP::Entry) 1 perl(fields) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -qp --provides perl-Net-LDAP-Server-0.43-2.fc26.noarch.rpm | sort | uniq -c 1 perl(Net::LDAP::Server) = 0.43 1 perl-Net-LDAP-Server = 0.43-2.fc26 Binary provides are Ok. > TODO: Please replace PERL_INSTALL_ROOT with more common DESTDIR. -make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT +%{__make} pure_install DESTDIR=$RPM_BUILD_ROOT Ok. > TODO: Please add 'examples' to %doc. +%doc examples Ok. The package looks good. Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx