[Bug 1398922] Review Request: uftrace - User-space function call tracer for C and C++ programs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1398922



--- Comment #4 from Yunying Sun <yunying.sun@xxxxxxxxx> ---
(In reply to Benjamin Kircher from comment #2)
> Thank you.
> 
> > 1. No version specified in %changelog.
> Fixed.
> 
> > Static libraries are discouraged. Add "--disable-static" in %configure, and add -devel package where *.so could be included.
> There are no static libraries in this package. The libmcount*.so files are
> actually needed to run the application and get loaded by the `uftrace`
> binary dynamically at run-time. I don't think this is really a plugin system
> but seems to work kind of the same way.
> 
Sorry, as a new packager myself, I misunderstood the rules about .so files.
There're no versioned shared library files in this package, so the unversioned
.so should be included in the base package. And since it has no static libs, no
header files, no need for a -devel package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]